Closed keith closed 9 years ago
This looks good to me :+1: . What was the issue with the macro definitions?
All of the pictured build errors are the same as this one. Just putting the space there fixes those errors but I'm not sure what ramifications that has. Also I imagine there's a build setting that could be specified to disable this, which would be idea.
Oh actually a few of those errors are fixed by explicitly adding:
@synthesize appearance = _appearance;
To MASShortCutView.m
For the SFBAudioEngine
errors, the linked frameworks archive in the README is old. There's a new version available from the main SFBAudioEngine
repo, direct link:
http://files.sbooth.org/SFBAudioEngine-dependencies.tar.bz2
If you replace the old libraries with these versions, are the errors fixed?
Or, as you said, there should be a build setting to disable that error. Some googling lead to -Wliteral-suffix
being the likely culprit.
I just pushed a commit to bump MASShortcut
to 1.3.1
. I built it with 2.0.1
as well and everything seemed fine, but this seems safer. Related to https://github.com/sonoramac/Podspecs/pull/6
Looks like these new dependencies have a very different folder structure:
I've tried -Wliteral-suffix
and -Wno-literal-suffix
and can't seem to make them work.
After this PR https://github.com/sonoramac/INAppStoreWindow and https://github.com/sonoramac/Sparkle can be deleted.
I guess manually editing the macros is the workaround for now :/ Looks great otherwise, thanks again!
AFNetworking
)Podfile.lock
no pods won't be updated unless explicitly runningpod update
The only other thing I had to do to build sonora was deal with some macro definitions from
SFBAudioEngine
. I'm not sure how to handle that long term.