Build with the newest version of CocoaPods

sonoramac / Sonora

A minimal, beautifully designed music player for OS X.

http://getsonora.com

Other

932 stars 135 forks source link

Build with the newest version of CocoaPods #63

Closed keith closed 9 years ago

keith commented 9 years ago

Update the pods (depends on https://github.com/sonoramac/Podspecs/pull/5) just enough to build sonora. Can probably update some other stuff (like AFNetworking)
Specify podspec sources so new builds don't have to manually clone https://github.com/sonoramac/Podspecs
Check in Podfile.lock no pods won't be updated unless explicitly running pod update
Move submodule to the supported Sparkle branch (I didn't do extensive testing here but it builds successfully)
It seems like mogenerator had some churn here.

The only other thing I had to do to build sonora was deal with some macro definitions from SFBAudioEngine. I'm not sure how to handle that long term.

indragiek commented 9 years ago

This looks good to me :+1: . What was the issue with the macro definitions?

keith commented 9 years ago

screen shot 2015-01-21 at 11 39 10

All of the pictured build errors are the same as this one. Just putting the space there fixes those errors but I'm not sure what ramifications that has. Also I imagine there's a build setting that could be specified to disable this, which would be idea.

keith commented 9 years ago

Oh actually a few of those errors are fixed by explicitly adding:

@synthesize appearance = _appearance;

To MASShortCutView.m

indragiek commented 9 years ago

For the SFBAudioEngine errors, the linked frameworks archive in the README is old. There's a new version available from the main SFBAudioEngine repo, direct link:

http://files.sbooth.org/SFBAudioEngine-dependencies.tar.bz2

If you replace the old libraries with these versions, are the errors fixed?

indragiek commented 9 years ago

Or, as you said, there should be a build setting to disable that error. Some googling lead to -Wliteral-suffix being the likely culprit.

keith commented 9 years ago

I just pushed a commit to bump MASShortcut to 1.3.1. I built it with 2.0.1 as well and everything seemed fine, but this seems safer. Related to https://github.com/sonoramac/Podspecs/pull/6

keith commented 9 years ago

Looks like these new dependencies have a very different folder structure: screen shot 2015-01-21 at 11 46 37

keith commented 9 years ago

I've tried -Wliteral-suffix and -Wno-literal-suffix and can't seem to make them work.

keith commented 9 years ago

After this PR https://github.com/sonoramac/INAppStoreWindow and https://github.com/sonoramac/Sparkle can be deleted.

indragiek commented 9 years ago

I guess manually editing the macros is the workaround for now :/ Looks great otherwise, thanks again!