search

sonos / dinghy

Easier cross-compilation for phones and single boards computers
Other
365 stars 44 forks source link

Test on macOS-13 (x86) and macOS-14 (arm) #206

Closed simlay closed 9 months ago

simlay commented 9 months ago

Github now has m1 runners. Using macOS-14 will exclusively run on M1s while macOS-13 will still be on intel.

simlay commented 9 months ago

@kali I see that you retried the CI run. I authored this PR hoping that the issues I was having in my CI's setup were specific to my project. I authored a repo and CI hoping it was the runner itself to file against the runner-images repo.

I'm not sure where to go from here.

briansmith commented 9 months ago

It would make more sense to me to target aarch64-apple-ios when the host is aarch64-apple-darwin, and x86_64-apple-ios when the host is x86_64-apple-darwin.

briansmith commented 9 months ago

Maybe try again now? I was able to cargo install cargo-dinghy and then use it on a macos-14 runner: https://github.com/rust-random/getrandom/pull/398.

simlay commented 9 months ago

It would make more sense to me to target aarch64-apple-ios when the host is aarch64-apple-darwin, and x86_64-apple-ios when the host is x86_64-apple-darwin.

Turns out you're right. Maybe rosetta-2 isn't in the m1 runners or has some quirks.

briansmith commented 9 months ago

Turns out you're right. Maybe rosetta-2 isn't in the m1 runners or has some quirks.

The symptom is an indefinite hang, right? Maybe macOS is showing the GUI prompt about installing Rosetta, and that's what's causing the hang?

simlay commented 9 months ago

I have no authority in this project, but LGTM. Thanks for doing this!

Thanks for the review! I'm glad to hear getrandom (and perhaps ring) is using dinghy!

@kali could you review/merge this when you get a chance?

briansmith commented 9 months ago

The symptom is an indefinite hang, right? Maybe macOS is showing the GUI prompt about installing Rosetta, and that's what's causing the hang?

That can't be the problem because I've run the prebuild x86_64 binary on a macos-14 runner.

kali commented 9 months ago

Thanks!

The -p/--platform is needed because, cargo dinghy will by default build for the host. This is by design, but it may not have been the best idea.