Fix inverted vim's popup menu for dark theme.

sonph / onehalf

Clean, vibrant and pleasing color schemes for Vim, Sublime Text, iTerm, gnome-terminal and more.

MIT License

1.78k stars 236 forks source link

Open lkhphuc opened 3 years ago

lkhphuc commented 3 years ago

Before: Screenshot 2021-02-16 at 15 37 53

After: Screenshot 2021-02-16 at 15 40 01

Fix according to the light theme.

imr0 commented 3 years ago

Hi, I think the popup parts should should be exchanged from fg to bg as well, i.e. should be

call s:h("PmenuSel", s:bg, s:blue, "")

and

call s:h("PmenuThumb", "", s:bg, "")

on lines 88 and 90, accordingly.

dwettstein commented 3 years ago

Fixes #111

dist1ll commented 2 years ago

How come this is still not merged? I think fixing this would spare many users of this theme trouble

mentos1386 commented 2 years ago

Is there a way to apply this "localy" so we don't have to wait for this to be merged?

harshad1 commented 1 year ago

@mentos1386 probably the easiest way is to use BBaoVanC/onehalf . It looks like they have merged this change in