search

sonph / onehalf

Clean, vibrant and pleasing color schemes for Vim, Sublime Text, iTerm, gnome-terminal and more.
MIT License
1.78k stars 236 forks source link

Comments bg color acts strangely #128

Open jerpint opened 2 years ago

jerpint commented 2 years ago

For some odd reason, only using this theme, the comments get a weird highlight added. This only happens with this theme and disappears the second I switch to another theme. Here is a screenshot of what it looks like:

image

Any idea how to fix this?

jerpint commented 2 years ago

opening my editor using the exact same vimrc, just nvim instead of vim, fixes the problem

ademille commented 2 years ago

I have the same problem. I've been using the color theme for quite a while and never had this problem, but I reinstalled all my plugins and I think it updated. I see the problem on nvim and vim. I'd love to know what happened. I ended up doing the following, which is obviously not ideal: Commented out the following line in onehalfdark.vim: call s:h("Comment", s:comment_fg, "", "italic") and added highlight Comment ctermfg=247 ctermbg=236 guifg=#919baa guibg=#282c34 to my init.vim I stripped my init.vim/.vimrc down to just the plugin manager and this theme and it still had the problem.

jerpint commented 2 years ago

im not entirely sure what the problem was, but i also noticed i had a separate colorscheme plugin with the same theme name that might have been causing conflicts

ademille commented 2 years ago

Hmm. That's interesting. I reverted back to an earlier commit of the plugin and it fixed it for me. In .vimrc/init.vim Plug 'sonph/onehalf', {'branch': '5bec08d', 'rtp': 'vim/'}

I did a little more digging and the latest commit broke the comments: * 141c775 - (grafted, HEAD -> master, origin/master, origin/HEAD) Italicize vim comments (#101) (1 year, 1 month ago) <Jason Wang> If you remove the "italic" portion, the comments highlight as expected again (which is basically the same thing as using the previous commit). Change call s:h("Comment", s:comment_fg, "", "italic") to call s:h("Comment", s:comment_fg, "", "")