search

sonph / onehalf

Clean, vibrant and pleasing color schemes for Vim, Sublime Text, iTerm, gnome-terminal and more.
MIT License
1.78k stars 236 forks source link

Suggestion: add bright and faint colours #152

Open matterhorn103 opened 1 month ago

matterhorn103 commented 1 month ago

I have been using onehalf in Konsole and love the look.

However, I recently mistakenly opened a bug report for fish because I thought the autosuggestion feature wasn't working, but it turned out that I just couldn't see the suggestions.

This is because they were being displayed in "bright black", and as the theme has black = bright black = faint black (i.e. the codes 30m, 1;30m and 2;30m produce the same result) and the "background" colour of the Konsole theme is also the same as "black"/30m, they were not visible.

For my own use I've now customized the Konsole theme so that the 8 numbered colours all have intense and faint versions:

image

I just did this simply and systematically by changing the saturation and value parameters for each colour as follows:

normal (\033[XXm) intense (\033[1;XXm) faint (\033[2;XXm)
colour 1 (XX = 30) S +20 V +30 S -20 V +0
colours 2-8 (31 to 37) S +20 V -20 S -20 V -20

The differences are subtle and so the emphases are not strong, which I think matches the subtlety of the colours of the theme.

Since a variety of applications will rely on the ability to make the colour bright/intense, and to a lesser extent to be able to make it faint, would it make sense to change the theme so it doesn't just always use the exact same colours? Or at least for the Konsole theme? Is this not also an issue that crops up in the other themes for vim etc.?