search

sonph / onehalf

Clean, vibrant and pleasing color schemes for Vim, Sublime Text, iTerm, gnome-terminal and more.
MIT License
1.78k stars 236 forks source link

Use gray for kitty color8 #92

Closed jawang35 closed 3 years ago

jawang35 commented 3 years ago

For kitty, color8 blends in with the background so that it's impossible to read. This is problematic in the example below with mocha test errors for Node.js:

Screen Shot 2020-09-15 at 11 41 45 PM

I chose the vim onehalf-dark mono2 color to make this legible. Here's the result with the same example:

Screen Shot 2020-09-15 at 11 41 13 PM
sonph commented 3 years ago

Sorry for the late reply, this looks fine to me.

I made the decision that I want brights to be the same as regular colors, so bright black is the same as the black background color. Probably should revisit that... I'm a light theme user so this problem wasn't noticeable.

Anyway, merging, thanks!

jawang35 commented 3 years ago

Makes sense. Thanks for merging. I love this color scheme. Good work.