search

sonph / onehalf

Clean, vibrant and pleasing color schemes for Vim, Sublime Text, iTerm, gnome-terminal and more.
MIT License
1.78k stars 236 forks source link

Reduced contrast on non-text characters in VIM on both light & dark #97

Closed RussBrown00 closed 3 years ago

RussBrown00 commented 3 years ago

This PR reduces the contrast between non-text and regular character colors

Dark Half After Change

Screen Shot 2020-10-14 at 5 13 33 PM

Light Half Afer Change

Screen Shot 2020-10-14 at 5 14 26 PM
sonph commented 3 years ago

Looks ok to me. Is it possible to use comment_fg instead? I'd prefer that we use a small set of colors and also that's consistent with Whitespace (line 125).

RussBrown00 commented 3 years ago

Looks ok to me. Is it possible to use comment_fg instead? I'd prefer that we use a small set of colors and also that's consistent with Whitespace (line 125).

The color comment works, I preferred something lighter than the comments personally, but if you want to keep it small I'll change it. I don't think the Whitespace colorspace actually does anything anymore. I haven't had it effect anything in years. but I agree they should match anyway....

So: 1) Make Whitespace the same as my new value 2) Just use the existing comment color for both

I'll resubmit when you confirm.

sonph commented 3 years ago

hl-Whitespace is a thing in neovim (but not vim).

Hmm actually after looking closely at your screenshots I have to agree that the lighter colors work better, especially on comment lines in the light theme. I can go with option 1. The difference isn't that pronounced in the dark theme, can we pick another lighter or darker color here? @kdungs if you have any opinions.

Also, cterm = 237 is the same as cursor line. Can you pick a different values? Refer to this 256 color table. 252 (#d0d0d0) for light theme and maybe 239 (#4e4e4e) for dark theme are closest to the colors you picked 🤔

kdungs commented 3 years ago

No strong opinions from my side as long as the whitespace markers are not the same as the text :)

RussBrown00 commented 3 years ago

I've updated the PR, hopefully, those changes are closer to desire. I've also moved the NonText next to WhiteSpace and they both use the same color palatte.

The light theme is lighter than the comment, but not by as much. This is mostly because I was afraid of going to close to the BG and having it lost on some LCD monitors due to brightness.

RussBrown00 commented 3 years ago

Looks good to me, thanks!

NP. Thanks for the theme. I assume you'll merge -- I can't