search

sonrisesoftware / project-dashboard

Project Dashboard for Ubuntu Touch
GNU General Public License v3.0
25 stars 4 forks source link

Fixed a couple of bitesize bugs #105

Closed krnekhelesh closed 10 years ago

krnekhelesh commented 10 years ago

Fixes Issue #45, #108 and #109

krnekhelesh commented 10 years ago

I have only improved the label style in the IssuePage.qml. I haven't changed it in other places like the IssuesPage.qml. I wanted to confirm with you before I do that.

iBelieve commented 10 years ago

Thanks for your work on this!

Regarding the labels on the issues list page and in the labels editor, I'm thinking its probably best to keep just the labels names and color them on the list page so it doesn't get overly cluttered.

And on the labels editor, maybe go with the square UbuntuShapes to the left of the labels, since we can't really do a Flow layout with the selector checkboxes?

Do you want to do that in this pull request or should I go ahead and merge this?

krnekhelesh commented 10 years ago

Yeah I agree to the suggestion above. I will add the square UbuntuShapes to left of the labels (similar to Ubuntu Tasks) in this pull request since it should only take a few lines of code to implement.

iBelieve commented 10 years ago

Great, thanks!

krnekhelesh commented 10 years ago

Here is how it looks now https://imgur.com/kFvMJVG

iBelieve commented 10 years ago

Looks great!

iBelieve commented 10 years ago

Are you ready to have it merged?

krnekhelesh commented 10 years ago

Yup I think it is ready now. Good to merge.