search

sonrisesoftware / project-dashboard

Project Dashboard for Ubuntu Touch
GNU General Public License v3.0
25 stars 4 forks source link

Added Debian Packaging #75

Closed krnekhelesh closed 10 years ago

krnekhelesh commented 10 years ago

Few things to note in this commit, I had to comment out the "Check" and "Clean" calls in the Makefile since it caused the debian build to fail. I asked Daniel Dholbach on irc about these errors, but he was unable to explain as to why those lines in the Makefile caused the build to fail. So I had to comment out those 2 lines.

iBelieve commented 10 years ago

Thanks for adding the Debian packaging!

I've just merged all my new work, so the check target will pass and the app will run.

As for the clean target, it's not really a clean target since it actually erases the db created by the app (which I use when I screw up the app bad enough :). So I've renamed it to erase_db since that makes more sense.

iBelieve commented 10 years ago

Here are instructions on how to get the latest changes from the main repository:

Do this once, to add the original repository back as a git remote:

git remote add upstream https://github.com/iBeliever/project-dashboard.git

Whenever you need to pull changes from the master branch of the original repository, run:

git fetch upstream
git merge upstream/master
krnekhelesh commented 10 years ago

Just a note, when I manually run qmltestrunner -input tests/unit, all unit tests pass properly. I just get the above error during debian packing.

iBelieve commented 10 years ago

I'm really not familiar with Debian packaging, but I'm assuming it's because it's building in a headless environment. Is there a way to run these commands before make check?

export DISPLAY=:99.0
sh -e /etc/init.d/xvfb start

That's what I run on my CI VM to set up a fake display.

krnekhelesh commented 10 years ago

Couldn't we rather change the check to unit_test or something? Since the check is reserved for special purposes in a Makefile? I tried adding,

export DISPLAY=:99.0
sh -e /etc/init.d/xvfb start

below the check in the Makefile, but I got the same error

iBelieve commented 10 years ago

Sure, let's rename it to something else - I didn't realize make check was used by Debian packaging. check was just the default name used by the Ubuntu SDK. If you do change it, please change it in .travis.yml as well.

krnekhelesh commented 10 years ago

Ok as of now, the debian package works as expected :) . I installed the project-dashboard_0.2_all.deb file and it looks pretty cool.

The only caveat being the icon. I had to revert back to project-dashboard.png since dh_install debian doesn't allow file renaming :/. Rest assured, this issue applies to other apps in the PPA atm (4 apps including this). So I will try to find a better solution in a later commit.

Please review and let me know if there is anything else that you might want me to fix.

krnekhelesh commented 10 years ago

You are right that the .desktop file is shared with the click package. However the click verification tool doesn't fail :) https://imgur.com/KyXaMXP. I noticed that it fails only when you set a absolute path for the icon file.

iBelieve commented 10 years ago

Cool, then I'll merge it. Thanks for packaging this and handling all the problems :)