sonuarya / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Regression: extra codecs (1.7 or 1.5) not available since r2456 #2919

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.r2469 with codec pack 1.7 (or 1.5)
2.no opus or other extra codecs visible in codec list

What is the expected output? What do you see instead?
3.r2456 with codec pack 1.7 (or 1.5)
4. opus and other extra codecs are visible in codec list

What version of the product are you using? On what device / operating
system?
r2469, Android (several versions, several devices)

Please provide any additional information below.
In r2468 iterating over them is commented out, which disabled listing them:

https://code.google.com/p/csipsimple/source/detail?r=2468 
+                   /*
317 319                     for (Entry<String, DynCodecInfos> availableCodec : 
availableCodecs.entrySet()) {
318 320                         DynCodecInfos dyn = availableCodec.getValue();
319 321                         if (!TextUtils.isEmpty(dyn.libraryPath)) {
...         
323 325                         }
324 326                     }
325 327                     cssCfg.setExtra_aud_codecs_cnt(i);
328 +                   */
326 329 

Original issue reported on code.google.com by jrwe...@gmail.com on 20 Mar 2015 at 11:38

GoogleCodeExporter commented 9 years ago
Issue Issue 2887 and Issue 2901 may be dups of this

Original comment by jrwe...@gmail.com on 20 Mar 2015 at 11:41

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 20 Mar 2015 at 2:17

GoogleCodeExporter commented 9 years ago
Issue 2901 has been merged into this issue.

Original comment by r3gis...@gmail.com on 20 Mar 2015 at 2:18

GoogleCodeExporter commented 9 years ago
Issue 2887 has been merged into this issue.

Original comment by r3gis...@gmail.com on 20 Mar 2015 at 2:18

GoogleCodeExporter commented 9 years ago
Thanks for the report.
Indeed, I forgot to commit the file. 
For the record was disabled because g726 codec was broken with recent ndk 
versions.
This was resulting in crashing the app.
g726 still needs to be debugged to find out why it makes things crash

Original comment by r3gis...@gmail.com on 20 Mar 2015 at 2:22

GoogleCodeExporter commented 9 years ago
Issue 2917 has been merged into this issue.

Original comment by r3gis...@gmail.com on 20 Mar 2015 at 8:54

GoogleCodeExporter commented 9 years ago
Thanks Regis! Confirm r2470 fixed it. The stable release r2457 in Google Play 
was (and is) still working.

Original comment by jrwe...@gmail.com on 21 Mar 2015 at 10:17

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 22 Jun 2015 at 11:31