search

sonvister / Binance

A .NET Standard Binance API library.
MIT License
229 stars 77 forks source link

Possible abstraction to include more exchanges #80

Open LadislavBohm opened 6 years ago

LadislavBohm commented 6 years ago

Hello, when looking at this library and how great it already is (really good job!), I'm thinking about possible abstractions that would allow creating client libraries for more exchanges based on principles from this one. I imagine creating something like an abstract nuget package that would contain all base code to create http/socket clients. It would handle rate limiting, fees, authentication, socket reconnection etc. Creating exchange-specific client would then require defining some basic stuff like url's, model classes etc. Do you think it is possible with the current state of this library? Or whether it is worth the amount of work (I would definitely help) required. Thanks

sonvister commented 6 years ago

@LadislavBohm, thanks.

I think that is something for the future. It is something I have envisioned from the beginning, but first I wanted to see what works best with Binance before abstracting.

LadislavBohm commented 6 years ago

I understand (just wanted to make this clear in the answer here), if this is planned for the future and there is still some more work in Binance implementation, you might want to close this issue and reopen it when the time comes.

evo11x commented 5 years ago

A bitmex version would be nice

alikalfaoglu commented 5 years ago

Bitmex or Bitfinex. Where you can short on bear market..

alikalfaoglu commented 5 years ago

@LadislavBohm, thanks.

I think that is something for the future. It is something I have envisioned from the beginning, but first I wanted to see what works best with Binance before abstracting.

By the way, I developed a bot, which is in beta, fully functional working and as far as I can see, there is not much to say for your lib. Working perfectly. Thanks.

alikalfaoglu commented 5 years ago

Binance will be supporting margin trading soon I guess, therefore no need for this in that case. At least, not needed for me..