Response wont get cached if request header has no-cache

sony / easyhttpcpp

A cross-platform HTTP client library with a focus on usability and speed

MIT License

163 stars 29 forks source link

Response wont get cached if request header has no-cache #1

Closed shekharhimanshu closed 5 years ago

shekharhimanshu commented 6 years ago

Brief overview

EasyHttp wont cache a response if the request header contains Cache-Control: no-cache directive inside it. According to RFC, a no-cache request directive means that any available cache response should not be used satisfy the request. Caching the response is allowed however.

Expected behavior

Response is cached.

Actual behavior

Response is not cached.

Steps to reproduce

Create a request with Cache-Control: no-cache header.
Execute it
Response is not cached.

shekharhimanshu commented 5 years ago

Fixed with https://github.com/sony/easyhttpcpp/releases/tag/2.0.0