Remove new lines in setting cmake variables.

sony / easyhttpcpp

A cross-platform HTTP client library with a focus on usability and speed

MIT License

163 stars 29 forks source link

Remove new lines in setting cmake variables. #10

Closed VirtualTim closed 4 years ago

VirtualTim commented 4 years ago

Attempting to make as is will result in the warning: WARNING: Value of WIN_CXX_SECURE_OVERLOAD_STANDARD_OPTIONS contained a newline and was truncated. I believe this was added in cmake 3.11.

I haven't actually been able to get this project to compile on Windows, but this looks like a good start.

shekharhimanshu commented 4 years ago

Hi @VirtualTim

Thanks a lot for the contribution! 💯 LGTM. Will merge.

shekharhimanshu commented 4 years ago

I haven't actually been able to get this project to compile on Windows, but this looks like a good start.

Let me know how it goes 👍