sony / flutter-elinux

Flutter tools for embedded Linux (eLinux)
BSD 3-Clause "New" or "Revised" License
424 stars 43 forks source link

Issue after update to flutter 3.13.0 #205

Closed jvieira88 closed 1 year ago

jvieira88 commented 1 year ago

Hi,

There seems to be an issue after the flutter update to 3.13.0 (#204). Just had a quick look but it seems to affect some widgets such as the DropdownButton and other buttons. I reverted back to #201 and it seems fine.

Example with #204 image

Example with #201: image

Maybe it's not related with flutter-elinux but just thought to bring it up.

HidenoriMatsubayashi commented 1 year ago

Sorry, what is your issue?

HidenoriMatsubayashi commented 1 year ago

The following template source files were updated in flutter 3.13.0.

Can you check if the files you are using are up to date? They can be found in /elinux directory.

HidenoriMatsubayashi commented 1 year ago

@jvieira88 Can you please check if this issue occurs on elinux-x11 backend too?

$ flutter-elinux run -d elinux-x11

The root cause might be https://github.com/sony/flutter-embedded-linux/pull/376.

jvieira88 commented 1 year ago

Hi @HidenoriMatsubayashi,

Running with X11 results in the same issue. However, both main.cc and flutter_embedder_options.h local to the project (under /elinux/runner/) differ from the source files you mentioned. Is there a way of refreshing these local files without having to manually execute a run command every time there is an update?

HidenoriMatsubayashi commented 1 year ago

However, both main.cc and flutter_embedder_options.h local to the project (under /elinux/runner/) differ from the source files you mentioned.

Okay. So please try https://github.com/sony/flutter-elinux/issues/205#issuecomment-1682880895.

Is there a way of refreshing these local files without having to manually execute a run command every time there is an update?

Unfortunately, there is no way to upgrade local elinux c++ files in existing projects. Please replace your local files manually.

jvieira88 commented 1 year ago

I confirm that it's all working fine with both wayland and X11 after copying the files from /flutter-elinux/templates/app/runner to the project /elinux/runner local folder. Something to keep in mind the next time I need to update the repository :)

HidenoriMatsubayashi commented 1 year ago

Great.

Something to keep in mind the next time I need to update the repository :)

I'll consider automatic-migration way in flutter-elinux.

Closing. Thanks.