search

sony / flutter-embedded-linux

Embedded Linux embedding for Flutter
BSD 3-Clause "New" or "Revised" License
1.2k stars 127 forks source link

Building flutter-engine with fontconfig support #289

Closed andreadaoud closed 1 year ago

andreadaoud commented 2 years ago

If we want to display CJK characters using system font, we have to enable fontconfig support. Just add --enable-fontconfig to ./flutter/tools/gn command. Could you please consider enabling this in your CI pipeline when you build the artifacts?

HidenoriMatsubayashi commented 2 years ago

Hi @taka-okayama

This request is understandable/reasonable to me.

Just add --enable-fontconfig to ./flutter/tools/gn command. Could you please consider enabling this in your CI pipeline when you build the artifacts?

Can you please address that? All you have to do is only adding --enable-fontconfig to the build script in the CI.

Updated to add --enable-fontconfig: https://github.com/sony/flutter-embedded-linux/wiki/Building-Flutter-Engine-from-source#4-build-embedder

HidenoriMatsubayashi commented 2 years ago

@taka-okayama ping

taka-okayama commented 2 years ago

@HidenoriMatsubayashi sorry, we have a problem in CI now.

HidenoriMatsubayashi commented 2 years ago

@taka-okayama Ok, then please change the recipe after the CI is green.

taka-okayama commented 1 year ago

https://github.com/flutter/flutter/issues/112919

HidenoriMatsubayashi commented 1 year ago

Thanks. Commented.

HidenoriMatsubayashi commented 1 year ago

@taka-okayama The issue was fixed. Please address this issue.

taka-okayama commented 1 year ago

@andreadaoud @HidenoriMatsubayashi

I've updated artifacts with --enable-fontconfig. Could you confirm?

HidenoriMatsubayashi commented 1 year ago

@taka-okayama

You mean you updated https://github.com/sony/flutter-embedded-linux/releases/tag/c08d7d5efc and its build includes that option? Or you just changed only the internal recipe?

taka-okayama commented 1 year ago

@HidenoriMatsubayashi

oh, sorry. Local CI completed but deployment step in CI was skipped because of no change in flutter version. I'm changing CI script to re-build artifacts forcibly(option).

HidenoriMatsubayashi commented 1 year ago

Understood, but it's OK for me to wait until next release.

andreadaoud commented 1 year ago

I've already compiled myself, so waiting until next release is also okay for me. But I'm willing to test anytime.

taka-okayama commented 1 year ago

@HidenoriMatsubayashi @andreadaoud

thanks for your patience. this change will be deployed next release.

HidenoriMatsubayashi commented 1 year ago

@taka-okayama Confirmed that this option was included in the artifacts for v3.3.5. Thanks. I'll close the issue.