search

sony / flutter-embedded-linux

Embedded Linux embedding for Flutter
BSD 3-Clause "New" or "Revised" License
1.16k stars 123 forks source link

Add support for HighDPI cursor themes #304

Closed vially closed 1 year ago

vially commented 1 year ago

The previous logic contained a hard-coded cursor theme size of 32 pixels and the cursor surface buffer scale was never configured (so it defaulted to a value of 1). This meant the cursor theme was blurry on HighDPI screens.

This pull-request attempts to fix that by:

Regarding the cursor size, it looks like it could also be retrieved using D-BUS via the org.freedesktop.portal.Settings interface of the xdg-desktop-portal (https://github.com/libsdl-org/SDL/pull/5998), but I'm not sure how important that is for flutter-embedded-linux (considering its mostly targeted at embedded use-cases).

HidenoriMatsubayashi commented 1 year ago

Thank you for sending the PR.

It's unclear whether we can contribute this software to flutter/engine, but do you agree to delegate all rights related to this PR to Sony?

vially commented 1 year ago

It's unclear whether we can contribute this software to flutter/engine, but do you agree to delegate all rights related to this PR to Sony?

Sure, I forgot to mention that I do in the pull-request: I agree to delegate all rights related to this pull-request to Sony.

For what it's worth, I'm working on a couple more fixes and I'm planning to submit pull-requests for those as well. Is there any way I can pre-emptively declare that I agree to delegate all rights to Sony for all my future pull-requests in this repository? If that's not possible, is there any particular message I should use for this purpose in all my future pull-requests?

HidenoriMatsubayashi commented 1 year ago

Thank you. It would be great if you can comment on delegating all rights related to your changes to Sony in a pull-request.