search

sony / gobreaker

Circuit Breaker implemented in Go
MIT License
2.89k stars 179 forks source link

Does this really require go 1.12? #24

Closed cep21 closed 5 years ago

cep21 commented 5 years ago

The go.mod file is set to work only with go 1.12. When building with go 1.11 I get errors around which version of Go is required. Is go 1.12 required? Can this limitation be removed from the go.mod?

vtolstov commented 5 years ago

what is the benefit of using go 1.11 and not use go 1.12? (with coming 1.13 release)

cep21 commented 5 years ago

There is none. I'm trying to compare libraries and want to be accurate or not on stating that sony/gobreaker requires go 1.12. (which it currently appears to since it does not build as a dependency on 1.11)

vtolstov commented 5 years ago

IMHO i think that gobreaker requirement need to still the go 1.12. most of the projects move to go 1.12 now as hard dep.

YoshiyukiMineo commented 5 years ago

I have confirmed that gobreaker works well in Go 1.10, 1.11 and 1.12. https://github.com/sony/gobreaker/blob/master/.travis.yml#L3-L5