sony / model_optimization

Model Compression Toolkit (MCT) is an open source project for neural network model optimization under efficient, constrained hardware. This project provides researchers, developers, and engineers advanced quantization and compression tools for deploying state-of-the-art neural networks.
https://sony.github.io/model_optimization/
Apache License 2.0
331 stars 53 forks source link

fix package discovery for wheel #1257

Closed irenaby closed 2 weeks ago

irenaby commented 2 weeks ago

Pull Request Description:

tests_pytest is included in the wheel as it was not explicitly excluded from find_packages. Use include instead of exclude in find_packages to automatically exclude any new non-product code.

Checklist before requesting a review:

irenaby commented 2 weeks ago

@ofirgo docs are not included in the package. find_packages only looks for python packages, anything else need to be included explicitly with other arguments (i also don't see any reason why docs would be included in the wheel). Including only the product src code is much more robust, it was pure coincidence that I notice this at all.

ofirgo commented 2 weeks ago

@ofirgo docs are not included in the package. find_packages only looks for python packages, anything else need to be included explicitly with other arguments (i also don't see any reason why docs would be included in the wheel). Including only the product src code is much more robust, it was pure coincidence that I notice this at all.

Ok, sounds reasonable