search

sony / nmos-cpp

An NMOS (Networked Media Open Specifications) Registry and Node in C++ (IS-04, IS-05)
Apache License 2.0
141 stars 80 forks source link

Switch one runner to windows-2022 to test VS 2022 #282

Closed garethsb closed 11 months ago

garethsb commented 1 year ago

281.

garethsb commented 1 year ago

Hm, Windows Server 2022 build succeeded and most tests worked fine. The BCP-003-01 tests showed:

* WARNING: Could not find an installation of 'testssl'. Some tests will be disabled.

And right at the top of the log:

Fatal error: No IPv4/IPv6 address(es) for "nmos-api.local" available
garethsb commented 1 year ago

Hey, @lo-simon,

I just noticed that after your PR https://github.com/AMWA-TV/nmos-testing/pull/678 bumped the testing tool's requirement for testssl.sh to v3.0.7, the nmos-cpp CI didn't get the same bump so I've just added it to this PR.

Before I did that, I thought we ought to have seen a message in the testoutput files like this:

 * WARNING: Version of 'testssl' does not match the expected '3.0.7'

Sure enough, it's there at the top of the file for the Ubuntu 22.04 runner for example.

But it's not there on the windows-2019 one, which like the windows-2022 one, has:

* WARNING: Could not find an installation of 'testssl'. Some tests will be disabled.

However, the BCP-003-01 test suite on the windows-2019 runner showed PASSes!

I don't understand...

garethsb commented 1 year ago

@lo-simon Seems we are now back where we were with this, ❌ BCP-003-01 can't run on windows-2022 runner for some reason... 😕

garethsb commented 11 months ago

Can this now work with latest nmos-testing without the monkey patch?

lo-simon commented 11 months ago

@garethsb, yes it should now work without the monkey patch, can you roll it back, and re-sync your fork? If you don't have time, I can do it, but I will have to cherry-pick your changes and do it on a new PR.

garethsb commented 11 months ago

@lo-simon Fingers crossed now https://github.com/AMWA-TV/nmos-testing/pull/832 is merged this simple change from one year ago finally works!!