search

sony / nmos-cpp

An NMOS (Networked Media Open Specifications) Registry and Node in C++ (IS-04, IS-05)
Apache License 2.0
141 stars 80 forks source link

Workaround for Avahi target name with current Conan recipe #299

Closed garethsb closed 1 year ago

garethsb commented 1 year ago

May resolve #298.

avahi/0.8@#10417ed9b1382e1c2b6916db4247dc40 uses CMakeDeps and therefore the target namespace is avahi:: not Avahi::.

@will-leathers-smith-sony, can you try this out? Unfortunately, this won't be tested by GitHub Actions, since the local conanfile.txt doesn't require the Conan avahi package, instead the GitHub Actions build-test workflow uses apt-get to install it.

will-leathers-smith-sony commented 1 year ago

I have tested this by deleting avahi from my local conan cache and deleting the package for nmos-cpp, then applying the fix to the relevant nmos-cpp cmake file inside Conan. Seems good to me.