Exact Frame Rate SDP Field for SMPTE 291 SDP Generation

sony / nmos-cpp

An NMOS (Networked Media Open Specifications) Registry and Node in C++ (IS-04, IS-05)

Apache License 2.0

141 stars 80 forks source link

Exact Frame Rate SDP Field for SMPTE 291 SDP Generation #344

Closed cmaberto closed 11 months ago

cmaberto commented 1 year ago

Seems like the exactframerate SDP field is not correctly written. Seems like the if statement for checking for exactframerate is incorrect in make_video_smpte291_sdp_parameters. Removing the not seemed to have fixed me issues with it, unless I am using the functions wrong for 2110-40 SDP creation.

garethsb commented 1 year ago

Thank you, @cmaberto, your fix is good. The exactframerate is already added correctly for video/raw but the not is wrong in the code for video/smpte291 here:

https://github.com/sony/nmos-cpp/blob/9ebb3ae3383743918514669edd0392e1b2187a04/Development/nmos/sdp_utils.cpp#L836

SDP test cases should be increased for ST 2110-40.

jonathan-r-thorpe commented 11 months ago

Resolved by #346