Fix SMPTE 291 exactframerate field

sony / nmos-cpp

An NMOS (Networked Media Open Specifications) Registry and Node in C++ (IS-04, IS-05)

Apache License 2.0

136 stars 79 forks source link

Fix SMPTE 291 exactframerate field #346

Closed garethsb closed 8 months ago

garethsb commented 9 months ago

Unit tests + basically same fix for #344 as proposed by @cmaberto in #345.

garethsb commented 9 months ago

New unit tests found another simple bug so I've fixed that too 🤦‍♂️

garethsb commented 8 months ago

@jonathan-r-thorpe I believe this is now failing just because #351 isn't merged yet... so I guess the proper procedure is to merge #351 into master, then merge master into this PR branch, check the CI results and then merge this to master. Sigh.

jonathan-r-thorpe commented 8 months ago

Agreed - tested #351 against the updated (but not merged SDPoker) and that is failing because exactframerate isn't present in the -40:2021 fmtp

jonathan-r-thorpe commented 8 months ago

Verified with the updated SDPoker. LGTM