search

sony / nmos-cpp

An NMOS (Networked Media Open Specifications) Registry and Node in C++ (IS-04, IS-05)
Apache License 2.0
136 stars 80 forks source link

Check usage of jwt-cpp in Conan and CMake #369

Open jonathan-r-thorpe opened 5 months ago

jonathan-r-thorpe commented 5 months ago

Warnings on Windows 2022 builds: 'return': conversion from '__int64' to 'uint32_t', possible loss of data https://github.com/sony/nmos-cpp/actions/runs/7818489184/job/21331360782#step:21:96

jonathan-r-thorpe commented 5 months ago

Also Windows 2019

garethsb commented 4 months ago

Warning fixed by https://github.com/Thalhammer/jwt-cpp/commit/364a5572f4b46bb9f4304cb1c92acec8ddb2c620 in upstream master but not included in a release yet.

Other thing to check is whether jwt-cpp should be represented by add_library(INTERFACE) since it is header-only. For reference, see https://github.com/Thalhammer/jwt-cpp/blob/364a5572f4b46bb9f4304cb1c92acec8ddb2c620/CMakeLists.txt#L91