search

sony / nnabla

Neural Network Libraries
https://nnabla.org/
Apache License 2.0
2.73k stars 334 forks source link

skip stft test related to librosa #1193

Closed TomonobuTsujikawa closed 1 year ago

TomonobuTsujikawa commented 1 year ago

This PR disables stft/istft tests temporary until the issue caused by latest numpy and librosa is addressed.

The latest numpy is incompatible with the former librosa 0.9.2 as it removes some deprecated APIs. Furthermore, if we upgrade librosa, stft and istft tests fail because the results exceed the acceptable threshold.

E           AttributeError: module 'numpy' has no attribute 'float'.
E           `np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
E           The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
E               https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
FAILED ../python/test/function/test_stft.py::test_stft_forward_backward[False-reflect-True-hanning-16-8-16-313-ctx0] - AssertionError: 
Not equal to tolerance rtol=1e-05, atol=2e-06
STFT forward test fails
Mismatched elements: 16 / 378 (4.23%)
Max absolute difference: 0.06575024
Max relative difference: 1.5977175
 x: array([[[ 1.940641e-01,  5.911000e-02, -2.210789e+00, -2.508574e+00,
         -3.478985e+00, -2.443173e+00,  1.921534e+00,  9.249956e-01,
          4.055836e+00,  6.924717e-02,  2.314725e+00,  2.696341e+00,...
 y: array([[[ 1.940641e-01,  5.911007e-02, -2.210789e+00, -2.508574e+00,
         -3.478985e+00, -2.443173e+00,  1.921534e+00,  9.249954e-01,
          4.055836e+00,  6.924711e-02,  2.314726e+00,  2.696341e+00,...