sony / nnabla

Neural Network Libraries
https://nnabla.org/
Apache License 2.0
2.73k stars 334 forks source link

Remove docker inspect in makefile #1214

Closed TomonobuTsujikawa closed 1 year ago

TomonobuTsujikawa commented 1 year ago

Currently we will only add hash value that is generated from dockerfile, and this hash value is used to decide if a rebuild is required or not.

if ! docker image inspect $(DOCKER_IMAGE_NAME_ID) >/dev/null 2>/dev/null;

If the requirements.txt changes, such as limiting the package version, the docker image won't rebuild promptly but use cache. It might cause potential error.

Now a days, docker itself has the cache mechanism and it seems to work correctly. So, this PR removes the docker inspect and uses docker cache mechanism.