search

sonyccd / roboclaw_ros

ros for roboclaw
BSD 2-Clause "Simplified" License
50 stars 92 forks source link

Bugfixes #6

Open gaya- opened 8 years ago

gaya- commented 8 years ago

Hey,

We used your driver in our teaching project and found some bugs. I can't make a PR because the commits to make your software work on our robots are mixed with bugfixing commits. So, here's just a list of commits that you might want to cherry-pick:

https://github.com/sonyccd/roboclaw_ros/commit/8c4513d4980181a6d3490a5efb11fdf592f48eab https://github.com/sonyccd/roboclaw_ros/commit/8d4054eb0a588bf9a517b93674def37f7ad7ee3e https://github.com/sonyccd/roboclaw_ros/commit/0a95f8ba63171e0ab067786d9ffbb1efb3f7435c

The last commit also includes a possibility to invert the motors, in case they are wired differently. It's an extra feature but it also includes a bugfix. The line https://github.com/sonyccd/roboclaw_ros/commit/0a95f8ba63171e0ab067786d9ffbb1efb3f7435c#diff-c00ddbd0620c770bb87191dbe474030cL231 is wrong, you can't use if enc1 in locals() to check if a variable has value. So if you don't want the feature I would at least get rid of this line.

Cheers and thanks for providing this! Gaya

doisyg commented 8 years ago

Is it possible to integrate these commits, that would be really useful!

sonyccd commented 7 years ago

Please make a pull request