search

sonyxperiadev / bug_tracker

Empty repository that is used as a bugtracker for Open Devices project
52 stars 13 forks source link

Timekeep fails to build when using android-14.0.0_r50 #837

Open mlehtima opened 4 months ago

mlehtima commented 4 months ago

Platform: Android 14 Device: XQ- DQ54 Kernel version: 5,4 Android version: Android 14 Software binaries version:

Previously working on Build worked with android-14.0.0_r34 but not anymore with android-14.0.0_r50

Description Build fails with error vendor/oss/timekeep/Android.mk: error: TimeKeep: Specifies both LOCAL_SDK_VERSION (system_34) and LOCAL_PRIVATE_PLATFORM_APIS (true) but should specify only one

Symptoms Build fails

How to reproduce Try to build android-14.0.0_r50 with the health HAL PRs to prevent failure of that part

Additional context Build uses the health HAL PRs to fix the build of those

MarijnS95 commented 4 months ago

Is an Android script setting this for us now? We removed assignment of LOCAL_SDK_VERSION in favour of LOCAL_PRIVATE_PLATFORM_APIS := true a long time ago (in https://github.com/sonyxperiadev/timekeep/commit/9d8bd470739a6bbef153f9837e8264bfa7c4ec35).

In any case it's only used to read a vendor prop which seems odd, ~I'd expect there to be a different way to read this without requiring private platform APIs nowadays?~ EDIT: Used to be via the "new" sysprop API which I did for opentelephony/ModemConfig but not yet for timekeep: https://github.com/sonyxperiadev/SonyOpenTelephony/pull/3/files. As you can see it switches from private APIs to a specific SDK version.

MarijnS95 commented 4 months ago

@mlehtima please try the fix linked above :)