MarijnS95
commented
3 weeks ago @rinigus that should have exactly nothing to do with what you call a "Related PR" unless the old code in question was broken such that .Restore() never got called before.
Scrolling the error message top-to-bottom and left-to-right with all unrelated lines is incredibly tedious and frustrating, so I'm cutting it down to the bare minimum that is important:
Abort message: 'terminating with uncaught exception of type St16invalid_argument: stoi: no conversion'
...
backtrace:
#00 pc 0000000000051994 /apex/com.android.runtime/lib64/bionic/libc.so (abort+164) (BuildId: 2c82bf49529e9aa25cb9e5eca777a56f)
#01 pc 000000000004910c /apex/com.android.vndk.v33/lib64/libc++.so (abort_message+248) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#02 pc 00000000000492d4 /apex/com.android.vndk.v33/lib64/libc++.so (demangling_terminate_handler()+208) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#03 pc 0000000000049e84 /apex/com.android.vndk.v33/lib64/libc++.so (std::__terminate(void (*)())+12) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#04 pc 00000000000494ec /apex/com.android.vndk.v33/lib64/libc++.so (__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*)+28) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#05 pc 0000000000049450 /apex/com.android.vndk.v33/lib64/libc++.so (__cxa_throw+116) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#06 pc 000000000009ae94 /apex/com.android.vndk.v33/lib64/libc++.so (std::__1::stoi(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long*, int)+384) (BuildId: ac7b79d1f77424245e84c9e5e12121c7)
#07 pc 000000000000ac38 /vendor/lib64/hw/android.hardware.health@2.0-impl-2.1-sony.so (device::sony::health::CycleCountBackupRestore::Read(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int&)+148) (BuildId: 47284e398f31910ce682e251b7e79c63)
#08 pc 000000000000ab4c /vendor/lib64/hw/android.hardware.health@2.0-impl-2.1-sony.so (device::sony::health::CycleCountBackupRestore::Restore()+36) (BuildId: 47284e398f31910ce682e251b7e79c63)
#09 pc 000000000000a1c0 /vendor/lib64/hw/android.hardware.health@2.0-impl-2.1-sony.so (device::sony::health::SonyHealth::SonyHealth(std::__1::unique_ptr<healthd_config, std::__1::default_delete<healthd_config> >&&)+116) (BuildId: 47284e398f31910ce682e251b7e79c63)
#10 pc 000000000000a0e0 /vendor/lib64/hw/android.hardware.health@2.0-impl-2.1-sony.so (HIDL_FETCH_IHealth+204) (BuildId: 47284e398f31910ce682e251b7e79c63)What, strangely, seems to happen is that std::invalid_argument that the health HAL is compiled with might be different than the std::invalid_argument that libc++.so is raising here (IIRC as defined at https://cs.android.com/android-llvm/toolchain/llvm-project/+/main:libcxx/src/string.cpp;l=62-64;drc=9783f28cbb155e4a8d49c12e1c60ce14dcfaf0c7).
Alternatively AOSP could be compiling our HAL without RTTI (https://stackoverflow.com/questions/74441543/why-stdinvalid-argument-is-not-caught-with-no-rtti-in-macos-m1-environment)? Again nothing that the "Related PR" changed?
bartcubbins
rinigus
Platform: nagara Device: pdx223 Kernel version: 5.15 Android version: android-14_r67 Software binaries version: Patched SW_binaries_for_Xperia_Android_13_5.15_v4a_nagara.zip
Previously working on
Same issue was for me on AOSP13 as well, recent builds.
Description
On boot, device is stuck on ANDROID logo. In logcat, there are failures with android.hardware.health@2.1:
Symptoms
Stuck on Android logo while booting
How to reproduce
New build
Additional context
Maybe important: last stock was
XQ-CT54_Customized EU-UK_64.2.A.2.185While maybe it cannot reach battery data, the code seems to have corresponding exception handling in https://github.com/sonyxperiadev/device-sony-common/blob/master/hardware/health/CycleCountBackupRestore.cpp#L92
I could make it work by adding
But I cannot figure out why the original exception does not catch it.
cc: @MarijnS95