search

sonyxperiadev / device-sony-common

70 stars 141 forks source link

[q-mr1] odm: Add build.prop cleaner #805

Closed ix5 closed 3 years ago

ix5 commented 3 years ago

Certain props need to be filtered out from the proprietary odm image ("Software Binaries") because they are device-specific, while the odm image is released per platform.

MarijnS95 commented 3 years ago

Shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

ix5 commented 3 years ago

Can't shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

You could use LOCAL_REQUIRED_MODULES, but afaics that does not guarantee execution ordering, rather only adds the required module to PRODUCT_PACKAGES.

If you've got a good idea, shoot. (@luk1337 time for the Polish Winged Hussar Cavalry?)

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

El Goog CADT.

jerpelea commented 3 years ago

you can just create a file /odm/build.prop

ix5 commented 3 years ago

you can just create a file /odm/build.prop

/odm/build.prop will not be recognized by the property service on Q anymore https://android.googlesource.com/platform/system/core/+/refs/tags/android-10.0.0_r41/init/property_service.cpp#892

Of course we could just manually read the file, but I think for now this is a good solution.