Closed MarijnS95 closed 3 years ago
Drop libqsocket
as well while you're at it https://github.com/sonyxperiadev/vendor-qcom-opensource-location/pull/31#discussion_r575657443
@ix5 That's an ODM dep though: 2ecc882b4c66cb1496f08248ff6605d30e7e340a
Roger
@ix5 Shall we revert that commit anyway? Perhaps up to @jerpelea to take up with his proprietaries :)
Revert away, I say
Doesn't seem like such a good idea in the end. That commit mentions tftpd?_server
:
$ readelf -d mnt/bin/tftp_server
Dynamic section at offset 0x191f8 contains 33 entries:
Tag Type Name/Value
0x0000000000000001 (NEEDED) Shared library: [libqsocket.so]
...
Oh I thought you were talking about the commit in location OSS. No, ofc alin can't drop libqsocket then.
@ix5 Ah, right. It looks like @kholk was too late to drop them, PR already merged. Oh well, we'll drop the extra baggage another time.
@ix5 @MarijnS95 they can be dropped in the next PR
@jerpelea Nah, I don't want explicit reverts.
~I think this is ready for merging then, though :wink:~ Oh, apart a force-push on your side. I'll rebase later.
Not applying this to Q, older branches (A10 r1) still reference the sdm845 HAL and some other branch where these may still exist. Even then these should likely all be transitive dependencies that are dynamically linked.
These GPS libraries do not exist on 8.1 nor 9.12 branches. We do not have any enforcement for existing packages in
PRODUCT_PACKAGES
just yet, but when we end up enabling that these will pop out. They are probably reminiscent of some ancient HAL 3 Android versions ago.