search

sonyxperiadev / device-sony-common

70 stars 143 forks source link

[URGENT] [COMMON] [R] rmt_storage: Add missing colon in property triggers to enable service #833

Closed MarijnS95 closed 3 years ago

MarijnS95 commented 3 years ago

Closes https://github.com/sonyxperiadev/bug_tracker/issues/679.

https://github.com/sonyxperiadev/bug_tracker/issues/679 reports issues with the modem failing to start. The log is pretty clear on why rmt_storage is not coming up:

I init    : Parsing file /vendor/etc/init/rmt_storage.rc...
E init    : /vendor/etc/init/rmt_storage.rc: 10: ParseTriggers() failed: && is the only symbol allowed to concatenate actions
E init    : /vendor/etc/init/rmt_storage.rc: 14: ParseTriggers() failed: && is the only symbol allowed to concatenate actions

A recent commit disabled rmt_storage for mdm basebands by only starting on sdm and msm basebands, but a colon got lost along the way.

Fixes: 28921cff ("rootdir: rmt_storage: Enabled based on baseband")

ix5 commented 3 years ago

This is necessary to fix my glaring mistake in 28921cf. MERGE please!

MarijnS95 commented 3 years ago

Whew, fixed target branch just in time. Forgot -B r-mr1 when created through gh pr create :sweat_smile: