sonyxperiadev / device-sony-common

70 stars 141 forks source link

[DNM][S] common.mk: Remove PRODUCT_BUILD_BOOT_IMAGE #837

Closed Haxk20 closed 3 years ago

Haxk20 commented 3 years ago

As of Android S enabling PRODUCT_BUILD_BOOT_IMAGE and BOARD_USES_RECOVERY_AS_BOOT is not allowed:

PRODUCT_BUILD_BOOT_IMAGE is true, but so is BOARD_USES_RECOVERY_AS_BOOT.
Skipping building boot image.

Some of the devices we support enable BOARD_USES_RECOVERY_AS_BOOT. Remove PRODUCT_BUILD_BOOT_IMAGE to build boot image on those devices.

Haxk20 commented 3 years ago

Yes every device that needs the removed definition will have to define it in device repo as google made both definitions here only settable once.