search

sonyxperiadev / device-sony-common

70 stars 143 forks source link

[r-mr1] common: Fix ims bindmount path #847

Closed sjllls closed 3 years ago

sjllls commented 3 years ago

IMS is broken with the wrong path, although it is still broken after this fix...

Paulbouchara commented 3 years ago

Oh my that typo.... Well yeah ims is broken and you need supplementary apps to make it work aka fetch from PE, attention if you're running enforcing you might have RIL crashing like a champ

sjllls commented 3 years ago

Oh my that typo.... Well yeah ims is broken and you need supplementary apps to make it work aka fetch from PE, attention if you're running enforcing you might have RIL crashing like a champ

Thanks, I will try it, why did IMS doesn't work with these apps in odm parition and PE choose to include them in device_sony_customization?

sjllls commented 3 years ago

@jerpelea q-mr1 branch also needs this commit, thanks!

Paulbouchara commented 3 years ago

Oh my that typo.... Well yeah ims is broken and you need supplementary apps to make it work aka fetch from PE, attention if you're running enforcing you might have RIL crashing like a champ

Thanks, I will try it, why did IMS doesn't work with these apps in odm parition and PE choose to include them in device_sony_customization?

It's because PE resign apps on build time with ota keys and it means odm apps have to be resigned, thus copied and built from apks extracted. Tho it needs additional apps/service to work and those can't be added to odm yet, that's why there's more apps on cust

MarijnS95 commented 3 years ago

@jerpelea q-mr1 branch also needs this commit, thanks!

Oopsie, should have submitted to q-mr1 so that it can be rebased into R :) - for next time :)

MarijnS95 commented 3 years ago

Thanks, I will try it, why did IMS doesn't work with these apps in odm parition and PE choose to include them in device_sony_customization?

We played around trying to make Android accept the signature of the APKs and give them extra permissions. That's easily doable, but their signature must be the same as those in the radio group because of sharedUserId which depends on local build keys, hence the need to re-sign the apks with those local keys as @Paulbouchara mentioned.