[q-mr1] Fix USB composition selector

[bartcubbins]

sys.usb.configfs from init.usb.rc is triggering generic rules found in /system/etc/init/hw/init.usb.configfs.rc which leads to the fact that the values that correspond to the real configuration of the device are overwritten by the generic (dummy) ones. Because of this, some USB modes such as USB tethering, cannot be enabled in the USB Preferences menu. Hence, change the prefix of sys.usb.configfs setting from "sys." to "vendor." in order to avoid triggering the behavior described above.

The change was successfully tested on Xperia 10+ (Mermaid) device, MTP, PTP, MIDI and USB tethering modes are enabled successfully and each of them was recognized by the PC.

[MarijnS95]

[master]

Isn't this applicable to R and perhaps Q as well? Would make for some nice cleanup.

[bartcubbins]

yes, this applies to all branches

[MarijnS95]

If you can rebase this on Q and target q-mr1, Alin's scripts will pick the task of rebasing R and master on top automagically.

[bartcubbins]

done!

[MarijnS95]

Looking a bit more into this, we're already using the vendor.sys. prefix for runtime things, though only for vendor.sys.keymaster.loaded and vendor.sys.listeners.*.

[bartcubbins]

Yes, it seems to me that vendor.sys. prefix is more suitable, I will update it soon

[bartcubbins]

And I forgot about one thing in the first path. I will split it

[bartcubbins]

now all the commits and their descriptions match what they do. sorry, working on a lot of different code, sometimes things like this get lost from view

[MarijnS95]

sorry, working on a lot of different code, sometimes things like this get lost from view

No worries, I'm actually quite glad someone serious is finally working on SODP, and that you're cleaning up commits on your own regard without needing to be asked :grin:

[1] https://github.com/FrankenRomP/android_system_core/blob/pie/adb/daemon/usb.cpp#L300

Can we link to official sources instead? This has moved: https://cs.android.com/android/platform/superproject/+/android-11.0.0_r40:system/core/adb/daemon/usb_ffs.cpp;l=301-302

[bartcubbins]

oh, I just really love (get used) to use the github search and forgot to replace the link with the official one. but hey, that's why review exists:) updated.

[MarijnS95]

@bartcubbins Github search is fine as long as you end up on aosp-mirror :stuck_out_tongue:, and reference a relatable tag/commit :)