init: qcrild.rc : Add vendor prefix to ril-daemon

sonyxperiadev / device-sony-common

70 stars 139 forks source link

init: qcrild.rc : Add vendor prefix to ril-daemon #874

Closed ShujathMohd closed 2 years ago

ShujathMohd commented 2 years ago

qcrild.rc is attempting to stop ril-daemon which doesnt exist (https://github.com/sonyxperiadev/device-sony-common/blob/s-mr1/rootdir/vendor/etc/init/qcrild.rc#L9) and errors out with the below message.

"init: Command 'stop ril-daemon' action=vendor.rild.libpath=/odm/lib64/libril-qc-hal-qmi.so (/vendor/etc/init/qcrild.rc:9) took 0ms and failed: service ril-daemon not found."

Instead we have vendor.ril-daemon service starting in the background.

"init: starting service 'vendor.ril-daemon'..."

Add the vendor prefix to ril-daemon.

Fixes the buggy sim detection on S.

bartcubbins commented 2 years ago

LGTM. Reference: https://android.googlesource.com/platform/hardware/ril/+/83035b57fc6f63f4e80c3a424f09a867150e3bbe

MarijnS95 commented 2 years ago

Please add the reference link to the commit.

That commit is from 2018, should this also be applied to at least r-mr1?

jerpelea commented 2 years ago

cherry-picked

bartcubbins commented 2 years ago

should this also be applied to at least r-mr1? yes, as I can see

ShujathMohd commented 2 years ago

cherry-picked

Thanks Alin, Its picked on R currently, Need it for S too.

MarijnS95 commented 2 years ago

Thanks Alin, Its picked on R currently, Need it for S too.

It's definitely on S:

ShujathMohd commented 2 years ago

Thanks Alin, Its picked on R currently, Need it for S too.

It's definitely on S:

Oops. my bad... Thanks Marijn