sonyxperiadev / device-sony-common

70 stars 139 forks source link

Add modem config for Turkcell (TR) #884

Closed farukr1 closed 2 years ago

farukr1 commented 2 years ago

After adding this, I can see the notification for the correct config file however, IMS still displays Not Registered. The same mbn file can be set active using Qualcomm PDC tool and IMS, VoLTE works that way, I'm not sure what the PDC tool does different than the ModemConfigService.

MarijnS95 commented 2 years ago

Are there any more modem configs / cell providers available on the ROM you pulled this from that are not yet in this repository? If so please add those too, that may be useful for others :)

MarijnS95 commented 2 years ago

Would you be able to squash the commits, and document in the title/body what device and ROM version they originated from? Helps us understand what's there and what's not.

MarijnS95 commented 2 years ago

Squashing does not mean closing :wink: - you'll have to force-push.

farukr1 commented 2 years ago

Sorry, I was struggling .'(

MarijnS95 commented 2 years ago

@farukr1 Performing good contributions is tricky but you're learning fast and nailed it in #885!

farukr1 commented 2 years ago

@MarijnS95 Thank you for the motivation, I admit I didn't study git well 😅