Closed farukr1 closed 2 years ago
Add that information to the commit message as you did with https://github.com/sonyxperiadev/device-sony-common/pull/884/commits/8f9bc13ef6d71182e9e98c7fcfa548bf46e01e21, information in the PR body gets lost from the merged commit.
It should be okay now.
That's almost perfect, thanks!
I couldn't help but notice that 3 out of 5 files are terminated with a newline. As far as I'm aware that shouldn't be the case, can you remove them to prevent possible invalid file paths? I don't think
ModemConfig
strips/trims the path so this'll result in a "file not found".
Sorry about that, I'll trim those and update here in the following hours.
Okay, no more sneaky newlines at the end.
Almost great! Note that when squashing, you don't need to add things like:
also: Remove one byte at the end cuz it is whitespace
Because that change is not part of your commit anymore, after squashing them together. As such, future readers will not understand what byte you are talking about; unless this is a remnant from the stock ROM in which case you should clearly mention that, ie. Also remove trailing newline in some files respective to stock, to prevent accidentally tripping up SODPs `ModemConfig`.
. And not in the least because shorthands like cuz
are not very professional...
Sorry about that too, it wasn't a remnant from stock so I deleted that line all together.
This adds modem config files for the following providers,
Firmware files are extracted from latest stock ROM (52.1.A.3.49) at /vendor/firmware_mnt/image/modem_pr/mcfg/configs