search

sonyxperiadev / device-sony-common

70 stars 139 forks source link

Replace sm8250 with $(KONA) #886

Closed LogicFan closed 2 years ago

LogicFan commented 2 years ago

Not all custom ROMs use KONA = sm8250. For example, the lineage uses KONA = kona. It'll cause problems to hard-code sm8250 everywhere.

This PR replaces all hard-coded sm8250 that is used for detecting TARGET_BOARD_PLATFORM to $(KONA).

MarijnS95 commented 2 years ago

I doubt Lineage uses this repository though, they have always had their own device trees which were fully stock-blob based.

LogicFan commented 2 years ago

lineage don't because currently, all officially supported devices are using stock-blob. But that doesn't stop someone from making lineage based on sodp (like me 😋). This will just make thing a little bit easier for people who want to make lineage based on sodp for edo platform.

MarijnS95 commented 2 years ago

Why don't we do the same for LITO/MSMNILE/TRINKET/LAHAINA (bar the ninja-merge)?

jerpelea commented 2 years ago

@MarijnS95 can be done for all

Paulbouchara commented 2 years ago

This would be super useful for custom rom porting on lineage based os

jerpelea commented 2 years ago

please PR

MarijnS95 commented 2 years ago

@jerpelea Done in https://github.com/sonyxperiadev/device-sony-common/pull/888.