search

sonyxperiadev / device-sony-common

70 stars 139 forks source link

use $(KONA) to replace hardcoded sm8250 #887

Closed LogicFan closed 2 years ago

LogicFan commented 2 years ago

No need for this, #886 will be auto-rebased into it.

Rather, help us out with replacing the rest of the platforms #886 (comment).

I can modify for the other platforms, but since I don't have a device other than edo platform, it's hard to verify the correctness.

also I think there will be a merge conflict to for the auto-rebase of this one?

MarijnS95 commented 2 years ago

I can modify for the other platforms, but since I don't have a device other than edo platform, it's hard to verify the correctness.

I've done this myself... https://github.com/sonyxperiadev/device-sony-common/pull/888

also I think there will be a merge conflict to for the auto-rebase of this one?

That merge conflict for introducing sm8350 and/or removing older unsupported SoCs will be addressed by using $(LAHAINA).

jerpelea commented 2 years ago

no longer needed