search

sonyxperiadev / device-sony-common

70 stars 139 forks source link

common-treble.mk: Build hostapd libraries #896

Closed hellobbn closed 1 year ago

hellobbn commented 1 year ago

Since wpa-suppliant is now switched to AIDL, it no longer builds the HIDL interfaces that the prebuilt software binaries need.

Build the HIDL interface to make the prebuilt executable happy.

MarijnS95 commented 1 year ago

Why isn't this already available on system?

hellobbn commented 1 year ago

I am not sure why it is not built by default. And is causing ld errors. Meybe the wifi part is switching to aidl and no longer depends on this? I will check later

MarijnS95 commented 1 year ago

Add the result of that investigation to the commit message and pull request description, makes it a whole lot easier to review and refer to in hindsight.

hellobbn commented 1 year ago

I have updated the commit message and pull request description

MarijnS95 commented 1 year ago

Thanks for documenting what you're doing here, that allows us/me to properly review this.

I don't think is a workaround we should be making, as you clarify yourself the Android system (since FCM 7) now needs/uses the AIDL version meaning hostapd won't work if our vendor compartment hosts a HIDL version instead. But at least we'll get told about this when bumping to FCM 7. It's an optional interface at least.

jerpelea commented 1 year ago

our next delivery is using AIDL and the change is valid

MarijnS95 commented 1 year ago

our next delivery is using AIDL and the change is valid

No, if our (next) delivery uses AIDL we should omit/remove the HIDL library entirely.