sonyxperiadev / device-sony-common

70 stars 139 forks source link

Fix building and booting on edo #903

Closed hellobbn closed 1 year ago

MarijnS95 commented 1 year ago

There's [DNM] in one of the commits?

MarijnS95 commented 1 year ago

And half the commits miss a body, please describe each commit instead of forcing everyone to do research on their own.

hellobbn commented 1 year ago

There's [DNM] in one of the commits?

this is a draft. The vendor.sensors.qesdk.rc is not needed on edo, however, the oem provided by sodp contains this file, which should be removed

hellobbn commented 1 year ago

And half the commits miss a body, please describe each commit instead of forcing everyone to do research on their own.

done

MarijnS95 commented 1 year ago

this is a draft

That is not at all clear from the title of this commit. Click "mark as draft" on the top-right.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests

hellobbn commented 1 year ago

this is a draft

That is not at all clear from the title of this commit. Click "mark as draft" on the top-right.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests

will this be fixed on software binary side?

hellobbn commented 1 year ago

I have removed the DNM commit