sonyxperiadev / device-sony-common

70 stars 139 forks source link

[T/U] vintf: Drop duplicate `com.qualcomm.qti.dpm.api` definition #904

Closed MarijnS95 closed 10 months ago

MarijnS95 commented 10 months ago

This service was originally added in a5f7f38c ("vintf: Add com.qualcomm.qti.dpm.api::IdpmQmi@1.0") and later had a deprecated vendor.qti.dpm.api entry (hosting the same interface) renamed to it in 81835713 ("qcrild.rc: add new ril services") via the vendor.hw.dataservices.xml file. The former commit should have likely renamed it outright, instead of adding a new definition, and Android 14 now rightfully complains that it found a duplicate:

getDeviceHalManifest: -22 VINTF parse error: Illformed file: /vendor/etc/vintf/manifest.xml: Duplicated manifest.hal entry com.qualcomm.qti.dpm.api: Conflicting FqInstance: @1.0::IdpmQmi/dpmQmiService (from /vendor/etc/vintf/manifest.xml) vs. @1.0::IdpmQmi/dpmQmiService (from /vendor/etc/vintf/manifest.xml). Check whether or not multiple modules providing the same HAL are installed.