Closed ShujathMohd closed 10 months ago
Thermals are showing as expected.
Can you drop the leading spaces before
:
in commit titles? It's not standard.
:eyes:
frameworks/opt/net/wifi/libwifi_hal/wifi_hal_common.cpp:194:7: error: no matching function for call to 'wifi_change_driver_state' if (wifi_change_driver_state(WIFI_DRIVER_STATE_ON) < 0) { ^
~~~~~~~
Commit titles still not fixed :(
sorry. I missed them
@ShujathMohd did you fix Extended Settings and modemconfig?
@ShujathMohd did you fix Extended Settings and modemconfig?
Nope, didnt get time to look into them
@ShujathMohd did you fix Extended Settings and modemconfig?
They build for me; is there a problem at runtime?
@ShujathMohd API of sysprop_library SomcModemProperties doesn't match with current.txt Please update current.txt by: m SomcModemProperties-dump-api && mkdir -p vendor/oss/opentelephony/ModemConfig/sysprop/api && rm -rf vendor/oss/opentelephony/ModemConfig/sysprop/api/SomcModemProperties-current.txt && cp -f out/soong/.intermediates/vendor/oss/opentelephony/ModemConfig/sysprop/SomcModemProperties_sysprop_library/api-dump.txt vendor/oss/opentelephony/ModemConfig/sysprop/api/SomcModemProperties-current.txt
@ShujathMohd packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:73: error: cannot find symbol private static final long BUILT_IN_DISPLAY_ID_MAIN = SurfaceControl.getPhysicalDisplayIds()[0]; ^ symbol: method getPhysicalDisplayIds() location: class SurfaceControl packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:281: error: cannot find symbol IBinder displayHandle = SurfaceControl.getPhysicalDisplayToken(dispId); ^ symbol: method getPhysicalDisplayToken(int) location: class SurfaceControl packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:282: error: incompatible types: IBinder cannot be converted to long SurfaceControl.DynamicDisplayInfo displayInfo = SurfaceControl.getDynamicDisplayInfo(displayHandle); ^ packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:413: error: cannot find symbol IBinder displayHandle = SurfaceControl.getPhysicalDisplayToken(BUILT_IN_DISPLAY_ID_MAIN); ^ symbol: method getPhysicalDisplayToken(long) location: class SurfaceControl packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:430: error: incompatible types: IBinder cannot be converted to long SurfaceControl.DynamicDisplayInfo displayInfo = SurfaceControl.getDynamicDisplayInfo(displayHandle); ^ packages/apps/ExtendedSettings/src/sonyxperiadev/extendedsettings/ExtendedSettingsFragment.java:451: error: cannot find symbol SurfaceControl.setDisplaySize(displayHandle, width, height); ^ symbol: method setDisplaySize(IBinder,int,int)
@jerpelea the SurfaceControl
portion of ES will need some love, we shouldn't just mess with it :)
@MarijnS95 let's remove it for now
Sure, please remove it instead of having something that doesn't work. It needs to be revisited entirely to work with the modern KMS and SDE composer anyway.
Can you drop the leading spaces before
:
in commit titles? It's not standard.