search

sonyxperiadev / device-sony-loire

17 stars 40 forks source link

Fluence #197

Closed richardtullberg closed 6 years ago

richardtullberg commented 6 years ago

Initial Fluence Audio Routing fixes

humberos commented 6 years ago

oh nice! If dmic is fixed then I think we could revert this: https://github.com/sonyxperiadev/device-sony-suzu/commit/59103648114943e6b0a5d5502b93b4ca070073b3#diff-7757ae3d5fee7079ec3e1c9d061f4d29

humberos commented 6 years ago

also, this https://github.com/sonyxperiadev/device-sony-kugo/commit/c64880a02ebebbae2b533f98b64d1c891f103720#diff-7757ae3d5fee7079ec3e1c9d061f4d29

richardtullberg commented 6 years ago

We dont need to revert it, I will just patch the new routing path with the old camcorder settings.

The camcorder setting is set for a single mic usecase according to Qcom, the fluence DMIC routing is for dualmic. This is just legacy from Xperia routing that we are trying to mix and match. Its somewhat confusing but we are dealing with each case as they come.

oshmoun commented 6 years ago

@richardtullberg I suppose that would then resolve the quiet audio when recording video?

Now about this PR generally... It seems to work great! yet to find an issue with audio after applying it Thanks for this :+1:

jerpelea commented 6 years ago

please keep fluence in each platform git because if may differ from platform to platform