search

sonyxperiadev / device-sony-loire

17 stars 40 forks source link

[DONOTMERGE] rootdir: vendor: update voip acdb ids #205

Closed oshmoun closed 5 years ago

oshmoun commented 6 years ago

The previous values were causing ADSP errors: 03-21 09:44:33.142 0 0 E send_adm_cal_block: DSP returned error[ADSP_EBADPARAM]

The default HAL values seem to be working fine, so switch to those.

Change-Id: I8d1085f4223ef9beaa9c3d6757a862adb79efb4d

oshmoun commented 6 years ago

this was done to hopefully fix the echo described in https://github.com/sonyxperiadev/bug_tracker/issues/106 it seems to not deliver the expected results, but it does seem to avoid the adsp errors. so this may be valid, that's unknown. ping @richardtullberg

jerpelea commented 6 years ago

@richardtullberg

richardtullberg commented 6 years ago

The acdb ids that would be used here are not maintained by Sony. They could work better than the ones maintained just because we are lucky since we are having issues with echo on acdb.

I think the issue we are having issues with echo stems from the fact that the usecase for us is audio record while the usecase on Xperia is voice call. There are features we do not have that Xperia uses which makes it very different.

WIthout touching anything else, does this patch fix the echo issues on Voip?

oshmoun commented 6 years ago

nope it doesn't. Echo still persists oh and about the usecase, that's indeed a good idea. it seems only logical that SIP uses the same usecase as a normal call. Do you think this can be changed in mixer paths only or would a change in hal be required?