search

sonyxperiadev / device-sony-loire

17 stars 40 forks source link

fstab: Split into early and latemount, reserve 128M on /data #269

Closed ix5 closed 4 years ago

ix5 commented 4 years ago

VERIFY ME! Calling @oshmoun and other loire owners.

Makes things neater with the stage-separated mounting logic in Q and later.

chris42 commented 4 years ago

Works on Kugo, still booting

ix5 commented 4 years ago

@chris42 is that on Android 10, with https://github.com/sonyxperiadev/device-sony-common/pull/751 applied?

How about with FDE encryption enabled? It should be standard, but some people disable it.

chris42 commented 4 years ago

@ix5 yes to android 10, #751 was not applied, as it was a build overnight. In this build FDE is disabled.

So I guess you want me to retest with #751 applied and FDE enabled? ;-)

ix5 commented 4 years ago

Please do

chris42 commented 4 years ago

I created sonyxperiadev/device-sony-common#756 to mirror the changes for q-mr1-legacy and solve a merge conflict. Will come back as soon as I have a build

chris42 commented 4 years ago

So the fstab changes are not an issue and will work with q-mr1-legacy. However the connected sonyxperiadev/device-sony-common#751 is something else. See comment over there.

MarijnS95 commented 4 years ago

@chris42 Correct, if mount_all has no argument passed it'll mount everything in fstab, which would otherwise be split by passing --early and --late.