sonyxperiadev / device-sony-maple

39 stars 33 forks source link

[maple] Back camera doesn't support 19MP photo resolution #33

Closed FluorescentHallucinogen closed 6 years ago

FluorescentHallucinogen commented 6 years ago

AOSP ROM has no 5056x3792 (4:3, 19.17MP) resolution that stock ROM has.

Other differences:

AOSP: AOSP

Stock: Stock

FluorescentHallucinogen commented 6 years ago

@sonyxperiadev @jerpelea @kholk @alviteri @dutchdeveloper PTAL.

FluorescentHallucinogen commented 6 years ago

This issue may affect other devices, not only Sony XZ Premium (maple).

BTW, effective pixel count of IMX400 image sensor is 5520 (H) x 3840 (V) (23:16, 21.2 MP). Is it possible to enable resolution higher than 5056x3792 (4:3, 19.17MP)?

YumeMichi commented 6 years ago

DRM issue?

FluorescentHallucinogen commented 6 years ago

@YumeMichi

DRM issue?

No. As @jerpelea explained in https://github.com/sonyxperiadev/device-sony-lilac/issues/5, AOSP ROM does not use the DRM keys for camera functionality.

jerpelea commented 6 years ago

camera is set to 17Mp 16:9

FluorescentHallucinogen commented 6 years ago

@jerpelea

camera is set to 17Mp 16:9

What do you mean? Could you please write exact resolution in pixels for 17Mp 16:9?

What camera API version you tested? Camera 2 API or Camera 1 API. List of available resolutions may vary depending on the camera API version.

Just checked in Open Camera app on Xperia XZ Premium (AOSP), I can succesfully shot only at 17MP maximum, but it is 172:97 (5504x3104), not 16:9.

FluorescentHallucinogen commented 6 years ago

@jerpelea Is it limited in binary blobs? Could you please enable (unlock) 19MP for AOSP?

kholk commented 6 years ago

First of all: it's not as easy as it sounds.

The 172:97 aspect ratio wanted to be 16:9, and it "sorta" is, internally... and we currently support the maximum resolution of 5504x3104 for IMX400, without hacks.

Btw, the situation surely needs to be carefully examined prior even being able to say "in the future" or "never".

FluorescentHallucinogen commented 6 years ago

@kholk

and we currently support the maximum resolution of 5504x3104 for IMX400, without hacks.

But what about 4:3 5056x3792 (19.17MP) resolution for IMX400, without hacks (not 5504x3104)? Why it is not available?

jerpelea commented 6 years ago

current implementation uses 5504x3104 as max resolution

JamesOuver commented 6 years ago

fastboot flash oem SW_binaries_for_Xperia_AOSP_N_MR1_4.4_v05_yoshino.img

target reported max download size of 536870912 bytes sending 'oem' (222444 KB)... OKAY [457.634s] writing 'oem'... FAILED (remote: Flashing is not allowed in Lock State) finished. total time: 457.638s

it is still there fashing vendor 7.1(23.10.2017) on xzp

JamesOuver commented 6 years ago

cannot flash vendor img without EMMA?

JamesOuver commented 6 years ago

fastboot flash oem SW_binaries_for_Xperia_AOSP_O_MR0_4.4_v05_yoshino.img

target reported max download size of 536870912 bytes sending 'oem' (218786 KB)... OKAY [450.132s] writing 'oem'... FAILED (remote: Flashing is not allowed in Lock State) finished. total time: 450.136s

it is still there fashing vendor 8.0(23.10.2017) on xzp

jerpelea commented 6 years ago

please note that we moved to a new domain https://developer.sony.com

jerpelea commented 6 years ago

for the moment there is no change for the camera resolution and when it will be we will comunicate it through the changelog

FluorescentHallucinogen commented 6 years ago

@jerpelea New binary blobs have been released for AOSP 8.0 (2018-01-12), 7.1 (2018-01-19), 8.1 (2018-01-26), but there's no word about change for the camera resolution in the changelogs. Is this issue fixed in any of these binary blobs?

jerpelea commented 6 years ago

as I stated in my previous comment if there will be a resolution change we will communicate it. this is not a bug!

FluorescentHallucinogen commented 6 years ago

@jerpelea Some "camera updates" are mentioned in the changelog for sw_binaries_for_xperia_android_8.1.6.4_r1_v12_yoshino.zip: https://developer.sony.com/develop/open-devices/latest-updates.

Is this issue finally fixed?

jerpelea commented 6 years ago

the camera is set to 19mp 4:3 which results in around 17mp 16:9

FluorescentHallucinogen commented 6 years ago

Why 5056x3792 can't be achieved on AOSP? Could you please explain the roots of this limitation?

FluorescentHallucinogen commented 6 years ago

BTW, I've also found that front (selfie) camera is also affected by this issue.

FluorescentHallucinogen commented 4 years ago

Any news on fixing this issue?

jerpelea commented 4 years ago

this is not and issue and will not be fixed we have to use the 16:9 as the default camera mode to achieve higher FPS