sonyxperiadev / device-sony-suzu

18 stars 40 forks source link

overlay: base: Update brightness settings #68

Closed Gray47Maxx closed 5 years ago

Gray47Maxx commented 5 years ago

Took @kholk 's akatsuki commit as an example and tweaked it a bit for the sake of getting even darker screen. Works like a charm on my suzu, so it's merge-ready PR.

stefanhh0 commented 5 years ago

It would be better to have this change in a single commit.

kholk commented 5 years ago

Please squash the commits.

Gray47Maxx commented 5 years ago

Will do in a couple of hours, sry for the mess

kholk commented 5 years ago

No problem, take your time

Gray47Maxx commented 5 years ago

2 sorry for that mess. Let me close and clean my branch, then I'll do a proper PR.

MarijnS95 commented 5 years ago

@Gray47Maxx No need to close this and create yet another PR. Just force-push to this branch and it'll all clean itself up nicely. (Except that github nowadays shows force-pushes, but only the commit history matters)

Gray47Maxx commented 5 years ago

Sorry, can't reopen it already because I've messed so much that I've deleted the whole repo :/

Git is, without doubt, not my strong point, but next time I'll be way more serious with that things.

MarijnS95 commented 5 years ago

Don't worry, we're all here to learn new things. Be it git, code or otherwise.

Reopening PR's has always been an issue. I've never gotten it to work, but after a quick search it turns out that the branch needs to point to the same commit when it was closed. New changes should be force-pushed only after reopening. Alin should have the power to do so.