sonyxperiadev / device-sony-tone

10 stars 25 forks source link

Devfreq configuration changes #120

Closed artem closed 6 years ago

artem commented 6 years ago

Ping @kholk

kholk commented 6 years ago

I don't know where you took these values from. I can tell you that what you wrote in the revert of Alin's commit cannot be logically true....

In any case, commit descriptions apart, you are actually decreasing the mbps zones to get more bus bandwidth (hence higher frequency) on lower levels, which can be wrong, or can be fine... Noone actually knows until a more extensive test is done.

To excuse what you did, you decreased the polling interval for the memlat, so that theoretically it responds faster and should idle faster (other than ramping up faster).

I really can't judge.

The only recommendation I can do here is to keep the polling interval for memlat as high as possible because, remember, the more checks happening in one second, the more computational power is required (so, overhead increases and you can be actually hurting performance instead of making it better).

That said, again... Well... Test it carefully! If it works as intended, then I'm fine with merging this!

Paulbouchara commented 6 years ago

After a little extended test I can give a feedback This makes the phone faster but at the cost of a massive stability hit and GPU corruption. I think it should be more tweaked

artem commented 6 years ago

I doubt it can be tweaked without appropriate tools and documentation :/

jerpelea commented 6 years ago

I think that we should leave those alone

kholk commented 6 years ago

We should revisit devfreq tuning after the common clock migration on k4.9, but of course, without just copying values from somewhere.