search

sonyxperiadev / device-sony-yoshino

19 stars 40 forks source link

Revert "PlatformConfig: Enable audio DSP instance identifier feature" #160

Closed stefanhh0 closed 4 years ago

stefanhh0 commented 4 years ago

This reverts commit 2aef4328a4b9e93312c5fdfc43120aa88110b291.

Yoshino has no support for get_instance_id since it has been introduced with acdb v5 but yoshino is using acdb v2.

Signed-off-by: Stefan Rücker s.ruecker@gmx.de

MarijnS95 commented 4 years ago

The same was found on Akatsuki initially, seeing the following in the logs (pasting for posterity):

06-26 18:12:50.357 12038 12042 D ACDB-LOADER: get_acdb_sw_major_version: ACDB SW Major version: 10
06-26 18:12:50.358 12038 12042 D         : ACDBFILE_MGR: Property for the pid 0001327F not found
06-26 18:12:50.358 12038 12042 D         : ACDB_COMMAND: Failed to fetch the property info for pid 0001327F 
06-26 18:12:50.358 12038 12042 E ACDB-LOADER: get_instance_id_support:Error in ACDB_CMD_GET_ADSP_INSTANCE_ID_SUPPORT_INFO:0
06-26 18:12:50.358 12038 12042 D ACDB-LOADER: acdb_loader_init_v4: snd_card_name:sdm845-tavil-snd-card, cvd_version:2.3,

Thanks!

kholk commented 4 years ago

Go on, Yoshino is not a ACDB v5 platform. Merge